Reviewed: https://review.opendev.org/690429
Committed:
https://git.openstack.org/cgit/openstack/nova/commit/?id=df03499843aa7fd6089bd4d07b9d0eb5a8c14b47
Submitter: Zuul
Branch: master
commit df03499843aa7fd6089bd4d07b9d0eb5a8c14b47
Author: Matt Riedemann <mriedem...@gmail.com>
Date: Tue Oct 22 17:59:32 2019 -0400
Fix listing deleted servers with a marker
Change I1aa3ca6cc70cef65d24dec1e7db9491c9b73f7ab in Queens,
which was backported through to Newton, introduced a regression
when listing deleted servers with a marker because it assumes
that if BuildRequestList.get_by_filters does not raise
MarkerNotFound that the marker was found among the build requests
and does not account for that get_by_filters method short-circuiting
if filtering servers with deleted/cleaned/limit=0. The API code
then nulls out the marker which means you'll continue to get the
marker instance back in the results even though you shouldn't,
and that can cause an infinite loop in some client-side tooling like
nova's CLI:
nova list --deleted --limit -1
This fixes the bug by raising MarkerNotFound from
BuildRequestList.get_by_filters if we have a marker but are
short-circuiting and returning early from the method based on
limit or filters.
Change-Id: Ic2b19c2aa06b3059ab0344b6ac56ffd62b3f755d
Closes-Bug: #1849409
** Changed in: nova
Status: In Progress => Fix Released
--
You received this bug notification because you are a member of Yahoo!
Engineering Team, which is subscribed to OpenStack Compute (nova).
https://bugs.launchpad.net/bugs/1849409
Title:
openstack server list --deleted --limit -1 hangs
Status in OpenStack Compute (nova):
Fix Released
Status in OpenStack Compute (nova) ocata series:
In Progress
Status in OpenStack Compute (nova) pike series:
In Progress
Status in OpenStack Compute (nova) queens series:
In Progress
Status in OpenStack Compute (nova) rocky series:
In Progress
Status in OpenStack Compute (nova) stein series:
In Progress
Status in OpenStack Compute (nova) train series:
In Progress
Bug description:
OpenStack Rocky:
When running `openstack server list --deleted --limit -1 hangs` it
will hang and not return.
A debug output is found in this pastebin
http://paste.openstack.org/show/785497/
and a direct curl is shown here
http://paste.openstack.org/show/785488/
It seems to be related to the marker as discussed here.
http://eavesdrop.openstack.org/irclogs/%23openstack-nova/%23openstack-
nova.2019-10-22.log.html#t2019-10-22T20:35:11
after the initial collection of 18 servers, for some reason it than
tried to grab with
https://192.168.23.35:8774/v2.1/428982d4248a419a933668b6a4dd14a0/servers/dtail?deleted=True&marker=8aab9854
-af8e-4e98-840a-192f15ae01f9
where the marker is the 18th deleted server in the list. it then loops
on this until you breakout.
To manage notifications about this bug go to:
https://bugs.launchpad.net/nova/+bug/1849409/+subscriptions
--
Mailing list: https://launchpad.net/~yahoo-eng-team
Post to : yahoo-eng-team@lists.launchpad.net
Unsubscribe : https://launchpad.net/~yahoo-eng-team
More help : https://help.launchpad.net/ListHelp
