Reviewed: https://review.opendev.org/734734 Committed: https://git.openstack.org/cgit/openstack/nova/commit/?id=10e9a9b9fc62a3cf72c3717e3621ed95d3cf5519 Submitter: Zuul Branch: master
commit 10e9a9b9fc62a3cf72c3717e3621ed95d3cf5519 Author: sunhao <suha9...@163.com> Date: Wed Jun 10 10:26:49 2020 +0800 Add checks for volume status when rebuilding When rebuilding, we should only allow detaching the volume with 'in-use' status, volume in status such as 'retyping' should not allowed. Change-Id: I7f93cfd18f948134c9cb429dea55740d2cf97994 Closes-Bug: #1489304 ** Changed in: nova Status: In Progress => Fix Released -- You received this bug notification because you are a member of Yahoo! Engineering Team, which is subscribed to OpenStack Compute (nova). https://bugs.launchpad.net/bugs/1489304 Title: Lack of volume status checks when detaching volume in rebuild. Status in OpenStack Compute (nova): Fix Released Bug description: Currently, when rebuilding an instance with volume attached, the Nova compute manager will directly call _detach_volume() which will skip the checks of volume status (volume_api.check_detach) and setting the volume to 'detaching' (volume_api.begin_detaching) at Cinder side. This is different with the normal volume detach process. Besides, when rebuilding, we should only allow detaching the volume with in-use status, volume in status such as 'retyping' should not allowed. To manage notifications about this bug go to: https://bugs.launchpad.net/nova/+bug/1489304/+subscriptions -- Mailing list: https://launchpad.net/~yahoo-eng-team Post to : yahoo-eng-team@lists.launchpad.net Unsubscribe : https://launchpad.net/~yahoo-eng-team More help : https://help.launchpad.net/ListHelp