Reviewed: https://review.opendev.org/c/openstack/glance/+/796885
Committed:
https://opendev.org/openstack/glance/commit/b55dbb28c644f84165d57b9346cbe8b34a0c731d
Submitter: "Zuul (22348)"
Branch: master
commit b55dbb28c644f84165d57b9346cbe8b34a0c731d
Author: Dan Smith <dansm...@redhat.com>
Date: Thu Jun 17 08:53:36 2021 -0700
Reproduce bug #1932337
This reproduces the behavior described in bug 1932337, where a post-
upgrade GET by a non-owning user will return an error for a valid image
because the cinder store migration cannot complete.
This asserts the broken behavior to reproduce the problem, and the
rest of the test will be enabled when the bug is fixed.
Note that the test for this was duplicating code from the base class,
and since some changes were needed to those methods, this removes the
duplication and modifies only the base.
Change-Id: I741e6377b3aa40c14d637f0fbdf396dc468f6ebd
** Changed in: glance
Status: In Progress => Fix Released
--
You received this bug notification because you are a member of Yahoo!
Engineering Team, which is subscribed to Glance.
https://bugs.launchpad.net/bugs/1932337
Title:
Cinder store migration will fail if first GET'er is not the owner
Status in Glance:
Fix Released
Status in Glance wallaby series:
Confirmed
Status in Glance xena series:
Fix Released
Bug description:
During an upgrade to Xena, cinder-backed image locations are migrated
to include the store name in the URL field. This is lazily done on the
first GET of the image. The problem is that the first user to GET an
image after the migration may not be an admin or the owner of the
image, as would be the case for a public or shared image. If that
happens, the user gets a 404 for a valid image because the DB layer
refuses the modify operation. This is logged:
2021-06-17 08:50:06,559 WARNING [glance.db.sqlalchemy.api] Attempted
to modify image user did not own.
The lazy migration code needs to tolerate this and allow someone else
to perform the migration without breaking non-owner GET operations
until the migration is complete.
To manage notifications about this bug go to:
https://bugs.launchpad.net/glance/+bug/1932337/+subscriptions
--
Mailing list: https://launchpad.net/~yahoo-eng-team
Post to : yahoo-eng-team@lists.launchpad.net
Unsubscribe : https://launchpad.net/~yahoo-eng-team
More help : https://help.launchpad.net/ListHelp
