Reviewed: https://review.opendev.org/c/openstack/nova/+/809934 Committed: https://opendev.org/openstack/nova/commit/f6206269b71d9bcaf65aa0313c21cc6b75a54fb3 Submitter: "Zuul (22348)" Branch: master
commit f6206269b71d9bcaf65aa0313c21cc6b75a54fb3 Author: Takashi Kajinami <tkaji...@redhat.com> Date: Sun Sep 19 00:06:56 2021 +0900 Fix the wrong exception used to retry detach API calls When cinderclient receives an error response from API, it raises one of the exceptions from the cinderclient.exceptions module instead of the cinderclient.apiclient.exceptions module. This change fixes the wrong exception used to detect 500 error from cinder API, so that API calls to detach volumes are properly retried. Closes-Bug: #1944043 Change-Id: I741cb6b29a67da8c60708c6251c441d778ca74d0 ** Changed in: nova Status: In Progress => Fix Released -- You received this bug notification because you are a member of Yahoo! Engineering Team, which is subscribed to OpenStack Compute (nova). https://bugs.launchpad.net/bugs/1944043 Title: Wrong exception is expected to retry volume detachment API calls Status in OpenStack Compute (nova): Fix Released Bug description: Description =========== The following change introduced the logic to retry cinder API calls to detach volumes. https://review.opendev.org/c/openstack/nova/+/669674 The logic detects the InternalServerError class from cindreclient.apiclient.exceptions. However this is wrong and these API calls raises the ClientException class from cinderclient.exceptions instead. Steps to reproduce ================== N/A Actual result ============= N/A Environment =========== N/A Logs & Configs ============== N/A To manage notifications about this bug go to: https://bugs.launchpad.net/nova/+bug/1944043/+subscriptions -- Mailing list: https://launchpad.net/~yahoo-eng-team Post to : yahoo-eng-team@lists.launchpad.net Unsubscribe : https://launchpad.net/~yahoo-eng-team More help : https://help.launchpad.net/ListHelp