Reviewed: https://review.opendev.org/c/openstack/nova/+/939411 Committed: https://opendev.org/openstack/nova/commit/a4580335682d2abd58e9cfc441a27d1e65e29d0c Submitter: "Zuul (22348)" Branch: master
commit a4580335682d2abd58e9cfc441a27d1e65e29d0c Author: Suiong Ng <[email protected]> Date: Thu Jan 16 11:08:46 2025 +0800 Fix parameter order in add_instance_info_to_node Corrected the parameter order in `add_instance_info_to_node`. Closes-Bug: #2092570 Change-Id: I1e7458a70a65f65f4da66d98d8fde6c031e3315e ** Changed in: nova Status: In Progress => Fix Released -- You received this bug notification because you are a member of Yahoo! Engineering Team, which is subscribed to OpenStack Compute (nova). https://bugs.launchpad.net/bugs/2092570 Title: rebuild instance result in error in 2024.2 Status in Ironic: Triaged Status in OpenStack Compute (nova): Fix Released Bug description: Attempting to rebuild an instance consistently results in an error in OpenStack version 2024.2, specifically with Ironic 26.1.2.dev11. Affected Versions: Master branch OpenStack 2024.2 Unaffected Versions: OpenStack 2023.2 OpenStack 2024.1 ======================= nova-compute-ironic.log ======================= 2024-12-27 07:32:04.216 7 INFO nova.compute.manager [None req-e5a601d1-5399-45dd-905d-8c24a8e8249e 76dbbb12acec41b3b1cb6d726f10748d 580b53c6252a4352b3545e854a7f0e34 - - default default] [instance: 7d3b5bd0-e389-4cc8-8903-42a34ed296f4] Rebuilding instance 2024-12-27 07:32:05.304 7 ERROR nova.compute.manager [None req-e5a601d1-5399-45dd-905d-8c24a8e8249e 76dbbb12acec41b3b1cb6d726f10748d 580b53c6252a4352b3545e854a7f0e34 - - default default] [instance: 7d3b5bd0-e389-4cc8-8903-42a34ed296f4] Setting instance vm_state to ERROR: TypeError: 'InstanceDriverMetadata' object is not subscriptable 2024-12-27 07:32:05.304 7 ERROR nova.compute.manager [instance: 7d3b5bd0-e389-4cc8-8903-42a34ed296f4] Traceback (most recent call last): 2024-12-27 07:32:05.304 7 ERROR nova.compute.manager [instance: 7d3b5bd0-e389-4cc8-8903-42a34ed296f4] File "/var/lib/kolla/venv/lib/python3.12/site-packages/nova/compute/manager.py", line 10866, in _error_out_instance_on_exception 2024-12-27 07:32:05.304 7 ERROR nova.compute.manager [instance: 7d3b5bd0-e389-4cc8-8903-42a34ed296f4] yield 2024-12-27 07:32:05.304 7 ERROR nova.compute.manager [instance: 7d3b5bd0-e389-4cc8-8903-42a34ed296f4] File "/var/lib/kolla/venv/lib/python3.12/site-packages/nova/compute/manager.py", line 3869, in rebuild_instance 2024-12-27 07:32:05.304 7 ERROR nova.compute.manager [instance: 7d3b5bd0-e389-4cc8-8903-42a34ed296f4] self._do_rebuild_instance_with_claim( 2024-12-27 07:32:05.304 7 ERROR nova.compute.manager [instance: 7d3b5bd0-e389-4cc8-8903-42a34ed296f4] File "/var/lib/kolla/venv/lib/python3.12/site-packages/nova/compute/manager.py", line 3955, in _do_rebuild_instance_with_claim 2024-12-27 07:32:05.304 7 ERROR nova.compute.manager [instance: 7d3b5bd0-e389-4cc8-8903-42a34ed296f4] self._do_rebuild_instance( 2024-12-27 07:32:05.304 7 ERROR nova.compute.manager [instance: 7d3b5bd0-e389-4cc8-8903-42a34ed296f4] File "/var/lib/kolla/venv/lib/python3.12/site-packages/nova/compute/manager.py", line 4143, in _do_rebuild_instance 2024-12-27 07:32:05.304 7 ERROR nova.compute.manager [instance: 7d3b5bd0-e389-4cc8-8903-42a34ed296f4] self.driver.rebuild(**kwargs) 2024-12-27 07:32:05.304 7 ERROR nova.compute.manager [instance: 7d3b5bd0-e389-4cc8-8903-42a34ed296f4] File "/var/lib/kolla/venv/lib/python3.12/site-packages/nova/virt/ironic/driver.py", line 1747, in rebuild 2024-12-27 07:32:05.304 7 ERROR nova.compute.manager [instance: 7d3b5bd0-e389-4cc8-8903-42a34ed296f4] self._add_instance_info_to_node(node, instance, image_meta, metadata, 2024-12-27 07:32:05.304 7 ERROR nova.compute.manager [instance: 7d3b5bd0-e389-4cc8-8903-42a34ed296f4] File "/var/lib/kolla/venv/lib/python3.12/site-packages/nova/virt/ironic/driver.py", line 414, in _add_instance_info_to_node 2024-12-27 07:32:05.304 7 ERROR nova.compute.manager [instance: 7d3b5bd0-e389-4cc8-8903-42a34ed296f4] patch = patcher.create(node).get_deploy_patch(instance, 2024-12-27 07:32:05.304 7 ERROR nova.compute.manager [instance: 7d3b5bd0-e389-4cc8-8903-42a34ed296f4] ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ 2024-12-27 07:32:05.304 7 ERROR nova.compute.manager [instance: 7d3b5bd0-e389-4cc8-8903-42a34ed296f4] File "/var/lib/kolla/venv/lib/python3.12/site-packages/nova/virt/ironic/patcher.py", line 65, in get_deploy_patch 2024-12-27 07:32:05.304 7 ERROR nova.compute.manager [instance: 7d3b5bd0-e389-4cc8-8903-42a34ed296f4] 'value': str(flavor['swap'])}) 2024-12-27 07:32:05.304 7 ERROR nova.compute.manager [instance: 7d3b5bd0-e389-4cc8-8903-42a34ed296f4] ~~~~~~^^^^^^^^ 2024-12-27 07:32:05.304 7 ERROR nova.compute.manager [instance: 7d3b5bd0-e389-4cc8-8903-42a34ed296f4] TypeError: 'InstanceDriverMetadata' object is not subscriptable 2024-12-27 07:32:05.304 7 ERROR nova.compute.manager [instance: 7d3b5bd0-e389-4cc8-8903-42a34ed296f4] 2024-12-27 07:32:08.346 7 INFO nova.compute.manager [None req-e5a601d1-5399-45dd-905d-8c24a8e8249e 76dbbb12acec41b3b1cb6d726f10748d 580b53c6252a4352b3545e854a7f0e34 - - default default] [instance: 7d3b5bd0-e389-4cc8-8903-42a34ed296f4] Successfully reverted task state from rebuild_spawning on failure for instance. 2024-12-27 07:32:08.349 7 ERROR oslo_messaging.rpc.server [None req-e5a601d1-5399-45dd-905d-8c24a8e8249e 76dbbb12acec41b3b1cb6d726f10748d 580b53c6252a4352b3545e854a7f0e34 - - default default] Exception during message handling: TypeError: 'InstanceDriverMetadata' object is not subscriptable To manage notifications about this bug go to: https://bugs.launchpad.net/ironic/+bug/2092570/+subscriptions -- Mailing list: https://launchpad.net/~yahoo-eng-team Post to : [email protected] Unsubscribe : https://launchpad.net/~yahoo-eng-team More help : https://help.launchpad.net/ListHelp
