Reviewed: https://review.opendev.org/c/openstack/horizon/+/949036 Committed: https://opendev.org/openstack/horizon/commit/e0336ac8099db1ac41542a13570539c3548fed41 Submitter: "Zuul (22348)" Branch: master
commit e0336ac8099db1ac41542a13570539c3548fed41 Author: Radomir Dopieralski <[email protected]> Date: Wed May 7 15:56:19 2025 +0200 Pass the value of STATIC_URL to the scss variable. The previous SCSS compiler used a hack to get the STATIC_URL value into a variable. With the new compiler, we can use a custom function to do this. Closes-Bug: #2110054 Change-Id: Ib9af6b1053e1bad84badd7959bb780a63117bb41 ** Changed in: horizon Status: In Progress => Fix Released -- You received this bug notification because you are a member of Yahoo! Engineering Team, which is subscribed to OpenStack Dashboard (Horizon). https://bugs.launchpad.net/bugs/2110054 Title: Serving horizon on custom STATIC_URL is broken Status in OpenStack Dashboard (Horizon): Fix Released Bug description: Issue description ================= With migration from django-pyscss to libsass it seems that templating of $static_url in SCSS: https://opendev.org/openstack/horizon/src/commit/1c1363e2efdcc6492c8a29f122b2838ac196993d/openstack_dashboard/static/dashboard/scss/_variables.scss#L8 As a result, font_awesome is returning 404 How to reproduce ================ 1. Set `WEBROOT = '/horizon'` 2. Set in Apache: `Alias /horizon/static /openstack/venvs/horizon-31.0.0.0b2.dev19/lib/python3.12/site-packages/static/` 3. Collect & Compress Expected behavior ================= Inside of output.1e250ccd434f.css: @font-face{font-family:'FontAwesome';src:url("/horizon/static/horizon/lib/font_awesome/fonts/fontawesome-webfont.eot?v=4.7.0") Actual result ============= @font-face{font-family:'FontAwesome';src:url("/static/horizon/lib/font_awesome/fonts/fontawesome-webfont.eot?v=4.7.0") To manage notifications about this bug go to: https://bugs.launchpad.net/horizon/+bug/2110054/+subscriptions -- Mailing list: https://launchpad.net/~yahoo-eng-team Post to : [email protected] Unsubscribe : https://launchpad.net/~yahoo-eng-team More help : https://help.launchpad.net/ListHelp
