Author: kasha
Date: Sat Jun 7 06:12:59 2014
New Revision: 1601065
URL: http://svn.apache.org/r1601065
Log:
YARN-2132. ZKRMStateStore.ZKAction#runWithRetries doesn't log the exception it
encounters. (Vamsee Yarlagadda via kasha)
Modified:
hadoop/common/trunk/hadoop-yarn-project/CHANGES.txt
hadoop/common/trunk/hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/main/java/org/apache/hadoop/yarn/server/resourcemanager/recovery/ZKRMStateStore.java
Modified: hadoop/common/trunk/hadoop-yarn-project/CHANGES.txt
URL:
http://svn.apache.org/viewvc/hadoop/common/trunk/hadoop-yarn-project/CHANGES.txt?rev=1601065&r1=1601064&r2=1601065&view=diff
==============================================================================
--- hadoop/common/trunk/hadoop-yarn-project/CHANGES.txt (original)
+++ hadoop/common/trunk/hadoop-yarn-project/CHANGES.txt Sat Jun 7 06:12:59 2014
@@ -142,6 +142,9 @@ Release 2.5.0 - UNRELEASED
YARN-2122. In AllocationFileLoaderService, the reloadThread should be
created
in init() and started in start(). (Robert Kanter via kasha)
+ YARN-2132. ZKRMStateStore.ZKAction#runWithRetries doesn't log the exception
+ it encounters. (Vamsee Yarlagadda via kasha)
+
OPTIMIZATIONS
BUG FIXES
Modified:
hadoop/common/trunk/hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/main/java/org/apache/hadoop/yarn/server/resourcemanager/recovery/ZKRMStateStore.java
URL:
http://svn.apache.org/viewvc/hadoop/common/trunk/hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/main/java/org/apache/hadoop/yarn/server/resourcemanager/recovery/ZKRMStateStore.java?rev=1601065&r1=1601064&r2=1601065&view=diff
==============================================================================
---
hadoop/common/trunk/hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/main/java/org/apache/hadoop/yarn/server/resourcemanager/recovery/ZKRMStateStore.java
(original)
+++
hadoop/common/trunk/hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/main/java/org/apache/hadoop/yarn/server/resourcemanager/recovery/ZKRMStateStore.java
Sat Jun 7 06:12:59 2014
@@ -998,13 +998,13 @@ public class ZKRMStateStore extends RMSt
throw new StoreFencedException();
}
} catch (KeeperException ke) {
+ LOG.info("Exception while executing a ZK operation.", ke);
if (shouldRetry(ke.code()) && ++retry < numRetries) {
- LOG.info("Waiting for zookeeper to be connected, retry no. + "
- + retry);
+ LOG.info("Retrying operation on ZK. Retry no. " + retry);
Thread.sleep(zkRetryInterval);
continue;
}
- LOG.debug("Error while doing ZK operation.", ke);
+ LOG.info("Maxed out ZK retries. Giving up!");
throw ke;
}
}