> On Sep 8, 2016, at 2:50 AM, Steve Loughran <ste...@hortonworks.com> wrote: > > I'm trying to do the review effort here even though I don't know detailed > bash, as I expect I don't know any less than others, and what better way to > learn than reviewing code written by people that do know bash?
Just a heads up that I'm using bash variable references. While not exactly rare, they are uncommon. [We use them in lots of places in the shell code already, so no new ground being broken.] > Could you submit a PR of that HADOOP-13341 branch, so I can review it there. Sure. https://github.com/apache/hadoop/pull/126 has been opened. Thanks! --------------------------------------------------------------------- To unsubscribe, e-mail: yarn-dev-unsubscr...@hadoop.apache.org For additional commands, e-mail: yarn-dev-h...@hadoop.apache.org