Tao Jie created YARN-6000: ----------------------------- Summary: Set modifier of interface Listener in AllocationFileLoaderService to public Key: YARN-6000 URL: https://issues.apache.org/jira/browse/YARN-6000 Project: Hadoop YARN Issue Type: Bug Reporter: Tao Jie
We removed public modifier of {{AllocationFileLoaderService.Listener}} in YARN-4997 since it trigger a findbugs warning. However it breaks Hive code in {{FairSchedulerShim}}. {code} AllocationFileLoaderService allocsLoader = new AllocationFileLoaderService(); allocsLoader.init(conf); allocsLoader.setReloadListener(new AllocationFileLoaderService.Listener() { @Override public void onReload(AllocationConfiguration allocs) { allocConf.set(allocs); } }); try { allocsLoader.reloadAllocations(); } catch (Exception ex) { throw new IOException("Failed to load queue allocations", ex); } if (allocConf.get() == null) { allocConf.set(new AllocationConfiguration(conf)); } QueuePlacementPolicy queuePolicy = allocConf.get().getPlacementPolicy(); if (queuePolicy != null) { requestedQueue = queuePolicy.assignAppToQueue(requestedQueue, userName); {code} As a result we should set the modifier back to public. -- This message was sent by Atlassian JIRA (v6.3.4#6332) --------------------------------------------------------------------- To unsubscribe, e-mail: yarn-dev-unsubscr...@hadoop.apache.org For additional commands, e-mail: yarn-dev-h...@hadoop.apache.org