Wangda Tan created YARN-7208: -------------------------------- Summary: CMAKE_C_STANDARD take effect in NodeManager package. Key: YARN-7208 URL: https://issues.apache.org/jira/browse/YARN-7208 Project: Hadoop YARN Issue Type: Bug Reporter: Wangda Tan Priority: Blocker
I just checked changes of this JIRA doesn't relate to issues I saw, I tried to revert this patch but issue is still the same. It seems the set (CMAKE_C_STANDARD) doesn't work for the nodemanager project. I hardcoded to change set (CMAKE_C_STANDARD 99) to set (CMAKE_C_STANDARD 90) in nodemanager project. (Since we have code uses C99-only syntax, so changing to 90 should fail build). I tried on two different environment: 1) Centos 6, cmake version 3.1.0, gcc 4.4.7 For both 99/90 standard, all fail. 2) OSX v10.12.4, cmake version 3.5.2, cc = "Apple LLVM version 8.1.0 (clang-802.0.42)". For both 99/90 standard, all succeeded. At least for the for loop in gpu-module.c is C99 only: {code} for (int i = 0; i < n_minor_devices_to_block; i++) { // ... } {code} -- This message was sent by Atlassian JIRA (v6.4.14#64029) --------------------------------------------------------------------- To unsubscribe, e-mail: yarn-dev-unsubscr...@hadoop.apache.org For additional commands, e-mail: yarn-dev-h...@hadoop.apache.org