Szilard Nemeth created YARN-10953: ------------------------------------- Summary: Make CapacityScheduler#getOrCreateQueueFromPlacementContext more easy to comprehend Key: YARN-10953 URL: https://issues.apache.org/jira/browse/YARN-10953 Project: Hadoop YARN Issue Type: Sub-task Reporter: Szilard Nemeth
1. Most of the method body is wrapped in an if-statement that checks if the queue is null. We could negate this and return immediately if the queue != null, so we don't need a large if statement. 2. Similarly in that large if body, there's a check forĀ fallbackContext.hasParentQueue(). If it's true, we are having yet another large if-body. We should also negate this condition and return immediately if it's false. -- This message was sent by Atlassian Jira (v8.3.4#803005) --------------------------------------------------------------------- To unsubscribe, e-mail: yarn-dev-unsubscr...@hadoop.apache.org For additional commands, e-mail: yarn-dev-h...@hadoop.apache.org