[ https://issues.apache.org/jira/browse/YARN-186?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13492418#comment-13492418 ]
Robert Joseph Evans commented on YARN-186: ------------------------------------------ The patch looks good, and so do the tests. Thanks. My only question is why were the following lines added to setup? {code} conf.set(YarnConfiguration.NM_LOCAL_DIRS, "file:///bin/echo"); conf.set(YarnConfiguration.NM_LOG_DIRS, "file:///dev/null"); {code} The test seems to pass just fine without them, and I did not understand their need. > Coverage fixing LinuxContainerExecutor > -------------------------------------- > > Key: YARN-186 > URL: https://issues.apache.org/jira/browse/YARN-186 > Project: Hadoop YARN > Issue Type: Test > Components: resourcemanager, scheduler > Reporter: Aleksey Gorshkov > Attachments: YARN-186-branch-0.23.patch, YARN-186-branch-2.patch, > YARN-186-trunk.patch > > > Added some tests for LinuxContainerExecuror > YARN-186-branch-0.23.patch patch for branch-0.23 > YARN-186-branch-2.patch patch for branch-2 > ARN-186-trunk.patch patch for trank -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira