[ https://issues.apache.org/jira/browse/YARN-184?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13499352#comment-13499352 ]
Alejandro Abdelnur commented on YARN-184: ----------------------------------------- Sandy, looks good except for something I've missed in my previous review. In the QueueManager, {code} public Collection<FSQueue> getQueues() { synchronized (queues) { return queues.values(); } } {code} The returned collection should be a copy of queues.values() as the returned collection is not threadsafe. > Remove unnecessary locking in fair scheduler, and address findbugs excludes. > ---------------------------------------------------------------------------- > > Key: YARN-184 > URL: https://issues.apache.org/jira/browse/YARN-184 > Project: Hadoop YARN > Issue Type: Improvement > Affects Versions: 2.0.2-alpha > Reporter: Sandy Ryza > Assignee: Sandy Ryza > Attachments: YARN-184-1.patch, YARN-184-2.patch, YARN-184.patch > > > In YARN-12, locks were added to all fields of QueueManager to address > findbugs. In addition, findbugs exclusions were added in response to > MAPREDUCE-4439, without a deep look at the code. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira