[ 
https://issues.apache.org/jira/browse/YARN-233?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13504770#comment-13504770
 ] 

Bikas Saha commented on YARN-233:
---------------------------------

Sorry for not being clear. Its totally fine to change native code as long as 
its backwards compatible wherever its used currently.
On the other hand creating ProcessIsAlive as a subclass of Shell does not seem 
to match the pattern of all the remaining simple operations like kill etc. I 
should word my comments better.

Rest of the changes look good.

                
> YARN support for execution of container on Windows
> --------------------------------------------------
>
>                 Key: YARN-233
>                 URL: https://issues.apache.org/jira/browse/YARN-233
>             Project: Hadoop YARN
>          Issue Type: Bug
>          Components: nodemanager
>    Affects Versions: trunk-win
>            Reporter: Chris Nauroth
>            Assignee: Chris Nauroth
>         Attachments: YARN-233-branch-trunk-win.3.patch, 
> YARN-233-branch-trunk-win.patch, YARN-233-branch-trunk-win.patch
>
>
> YARN container launch code requires updates for compatibility with Windows.  
> Instead of launching and killing tasks via generated bash scripts and kill, 
> use generated cmd scripts and winutils for task management.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

Reply via email to