[
https://issues.apache.org/jira/browse/YARN-170?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13505649#comment-13505649
]
Hadoop QA commented on YARN-170:
--------------------------------
{color:red}-1 overall{color}. Here are the results of testing the latest
attachment
http://issues.apache.org/jira/secure/attachment/12555066/YARN-170-1.patch
against trunk revision .
{color:green}+1 @author{color}. The patch does not contain any @author
tags.
{color:red}-1 tests included{color}. The patch doesn't appear to include
any new or modified tests.
Please justify why no new tests are needed for this
patch.
Also please list what manual steps were performed to
verify this patch.
{color:green}+1 javac{color}. The applied patch does not increase the
total number of javac compiler warnings.
{color:green}+1 javadoc{color}. The javadoc tool did not generate any
warning messages.
{color:green}+1 eclipse:eclipse{color}. The patch built with
eclipse:eclipse.
{color:green}+1 findbugs{color}. The patch does not introduce any new
Findbugs (version 1.3.9) warnings.
{color:green}+1 release audit{color}. The applied patch does not increase
the total number of release audit warnings.
{color:green}+1 core tests{color}. The patch passed unit tests in
hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-nodemanager.
{color:green}+1 contrib tests{color}. The patch passed contrib unit tests.
Test results:
https://builds.apache.org/job/PreCommit-YARN-Build/178//testReport/
Console output: https://builds.apache.org/job/PreCommit-YARN-Build/178//console
This message is automatically generated.
> NodeManager stop() gets called twice on shutdown
> ------------------------------------------------
>
> Key: YARN-170
> URL: https://issues.apache.org/jira/browse/YARN-170
> Project: Hadoop YARN
> Issue Type: Bug
> Components: nodemanager
> Affects Versions: 2.0.2-alpha
> Reporter: Sandy Ryza
> Assignee: Sandy Ryza
> Attachments: YARN-170-1.patch, YARN-170.patch
>
>
> The stop method in the NodeManager gets called twice when the NodeManager is
> shut down via the shutdown hook.
> The first is the stop that gets called directly by the shutdown hook. The
> second occurs when the NodeStatusUpdaterImpl is stopped. The NodeManager
> responds to the NodeStatusUpdaterImpl stop stateChanged event by stopping
> itself. This is so that NodeStatusUpdaterImpl can notify the NodeManager to
> stop, by stopping itself in response to a request from the ResourceManager
> This could be avoided if the NodeStatusUpdaterImpl were to stop the
> NodeManager by calling its stop method directly.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
