[ 
https://issues.apache.org/jira/browse/YARN-170?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13546866#comment-13546866
 ] 

Hudson commented on YARN-170:
-----------------------------

Integrated in Hadoop-Hdfs-trunk #1279 (See 
[https://builds.apache.org/job/Hadoop-Hdfs-trunk/1279/])
    YARN-170. Change NodeManager stop to be reentrant. Contributed by Sandy 
Ryza. (Revision 1429796)

     Result = FAILURE
vinodkv : 
http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1429796
Files : 
* /hadoop/common/trunk/hadoop-yarn-project/CHANGES.txt
* 
/hadoop/common/trunk/hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-nodemanager/src/main/java/org/apache/hadoop/yarn/server/nodemanager/NodeManager.java
* 
/hadoop/common/trunk/hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-nodemanager/src/main/java/org/apache/hadoop/yarn/server/nodemanager/NodeManagerEvent.java
* 
/hadoop/common/trunk/hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-nodemanager/src/main/java/org/apache/hadoop/yarn/server/nodemanager/NodeManagerEventType.java
* 
/hadoop/common/trunk/hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-nodemanager/src/main/java/org/apache/hadoop/yarn/server/nodemanager/NodeStatusUpdaterImpl.java
* 
/hadoop/common/trunk/hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-nodemanager/src/test/java/org/apache/hadoop/yarn/server/nodemanager/TestNodeStatusUpdater.java

                
> NodeManager stop() gets called twice on shutdown
> ------------------------------------------------
>
>                 Key: YARN-170
>                 URL: https://issues.apache.org/jira/browse/YARN-170
>             Project: Hadoop YARN
>          Issue Type: Bug
>          Components: nodemanager
>    Affects Versions: 2.0.2-alpha
>            Reporter: Sandy Ryza
>            Assignee: Sandy Ryza
>             Fix For: 2.0.3-alpha
>
>         Attachments: YARN-170-1.patch, YARN-170-20130107.txt, 
> YARN-170-2.patch, YARN-170-3.patch, YARN-170.patch
>
>
> The stop method in the NodeManager gets called twice when the NodeManager is 
> shut down via the shutdown hook.
> The first is the stop that gets called directly by the shutdown hook.  The 
> second occurs when the NodeStatusUpdaterImpl is stopped.  The NodeManager 
> responds to the NodeStatusUpdaterImpl stop stateChanged event by stopping 
> itself.  This is so that NodeStatusUpdaterImpl can notify the NodeManager to 
> stop, by stopping itself in response to a request from the ResourceManager
> This could be avoided if the NodeStatusUpdaterImpl were to stop the 
> NodeManager by calling its stop method directly.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

Reply via email to