[ 
https://issues.apache.org/jira/browse/YARN-316?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13561911#comment-13561911
 ] 

Chris Nauroth commented on YARN-316:
------------------------------------

{quote}
I am in favor of keeping a windows specific path for classpath jar now and 
definitely open a jira to merge the code paths later on.
{quote}

Yes, that does sound like the safer approach.  I have filed YARN-358 for this.

{quote}
So even the simple class name and symlink are just about working for the 
current set of test case names. We might need another fix for this down the 
road.
{quote}

This is true.  Do you think it would be valuable to add a check in 
{{DefaultContainerExecutor#launchContainer}} to see if the path to the 
container launch script is > 260 characters, and if so, fail fast with a 
descriptive error message?  This could be helpful even for the main product 
code, in case someone deploys on Windows with a path configured in 
yarn.nodemanager.local-dirs that is too long.  I'll see if I can incorporate 
this in my next version of this patch.

                
> YARN container launch may exceed maximum Windows command line length due to 
> long classpath
> ------------------------------------------------------------------------------------------
>
>                 Key: YARN-316
>                 URL: https://issues.apache.org/jira/browse/YARN-316
>             Project: Hadoop YARN
>          Issue Type: Bug
>          Components: nodemanager
>    Affects Versions: 3.0.0, trunk-win
>            Reporter: Chris Nauroth
>            Assignee: Chris Nauroth
>         Attachments: YARN-316-branch-trunk-win.1.patch, 
> YARN-316-branch-trunk-win.2.patch
>
>
> On Windows, a command line longer than 8192 characters will fail.  This can 
> cause YARN container launch to fail on Windows if the classpath argument 
> exceeds this limit.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

Reply via email to