[
https://issues.apache.org/jira/browse/YARN-443?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13596141#comment-13596141
]
Bikas Saha commented on YARN-443:
---------------------------------
winutils will not support nice. and windows support does not use cygwin.
infact, it removes cygwin. so the above patch will likely cause all tests to
fail on Windows :)
Why dont we set a local variable with the result of the scheduling
configuration? And use that in the non-Windows part of the command line
generation? Later we can use that value for the windows part when it gets
supported. YARN-456.
Minor nit, how about a default value in config instead of the hard coded 0 for
priority?
Also if the comments describing the config could be made easier for someone
implementing YARN-456 or using the feature. something like. The value must be a
+ve integer and higher values mean lower priority? Then the current comments
could explain how the value is used in linux.
I wish linuxcontainerexecutor.java did not need to replicate almost all the
changes made in defaultcontainerexecutor :(
> allow OS scheduling priority of NM to be different than the containers it
> launches
> ----------------------------------------------------------------------------------
>
> Key: YARN-443
> URL: https://issues.apache.org/jira/browse/YARN-443
> Project: Hadoop YARN
> Issue Type: Improvement
> Components: nodemanager
> Affects Versions: 2.0.3-alpha, 0.23.6
> Reporter: Thomas Graves
> Assignee: Thomas Graves
> Attachments: YARN-443-branch-0.23.patch, YARN-443-branch-0.23.patch,
> YARN-443-branch-2.patch, YARN-443.patch, YARN-443.patch, YARN-443.patch,
> YARN-443.patch
>
>
> It would be nice if we could have the nodemanager run at a different OS
> scheduling priority than the containers so that you can still communicate
> with the nodemanager if the containers out of control.
> On linux we could launch the nodemanager at a higher priority, but then all
> the containers it launches would also be at that higher priority, so we need
> a way for the container executor to launch them at a lower priority.
> I'm not sure how this applies to windows if at all.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
