[ 
https://issues.apache.org/jira/browse/YARN-487?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Chris Nauroth updated YARN-487:
-------------------------------

    Attachment: YARN-487.1.patch

This patch changes {{LocalDirsHandlerService}} to go through {{Path#toString}}, 
which already has the correct logic to strip the leading slash if necessary on 
Windows.  I also updated {{TestDiskFailures#testDirFailuresOnStartup}} to do 
the same, so that both sides are in agreement.  With this patch, the test 
passes successfully on both Mac and Windows.
                
> TestDiskFailures fails on Windows due to path mishandling
> ---------------------------------------------------------
>
>                 Key: YARN-487
>                 URL: https://issues.apache.org/jira/browse/YARN-487
>             Project: Hadoop YARN
>          Issue Type: Bug
>          Components: nodemanager
>    Affects Versions: 3.0.0
>            Reporter: Chris Nauroth
>            Assignee: Chris Nauroth
>         Attachments: YARN-487.1.patch
>
>
> {{TestDiskFailures#testDirFailuresOnStartup}} fails due to insertion of an 
> extra leading '/' on the path within {{LocalDirsHandlerService}} when running 
> on Windows.  The test assertions also fail to account for the fact that 
> {{Path}} normalizes '\' to '/'.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

Reply via email to