[
https://issues.apache.org/jira/browse/YARN-498?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13612923#comment-13612923
]
Bikas Saha commented on YARN-498:
---------------------------------
Looks good. Thanks for the changes. +1. Some minor nits
1) Might be good to do currentTime - startTime > 5 seconds instead of using a
counter. That way its delinked from the the sleep period of the loop.
2) Can we include the expected and actual states in the final exception. It
would be convenient to see what state the app was in when we expected it to
reach some other state.
3) The new test might have to change because YARN-417 changed DistShell to not
accept 0 container launches. So the test will get an exception but not the one
it expects. Maybe add check that exception contains expected message?
> Unmanaged AM launcher does not set various constants in env for an AM, also
> does not handle failed AMs properly
> ---------------------------------------------------------------------------------------------------------------
>
> Key: YARN-498
> URL: https://issues.apache.org/jira/browse/YARN-498
> Project: Hadoop YARN
> Issue Type: Bug
> Reporter: Hitesh Shah
> Assignee: Hitesh Shah
> Attachments: YARN-498.1.patch, YARN-498.2.patch, YARN-498.3.patch,
> YARN-498.wip.patch
>
>
> Currently, it only sets the app attempt id which is really not required as
> AMs are only expected to extract it from the container id.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
