[
https://issues.apache.org/jira/browse/YARN-493?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13617116#comment-13617116
]
Ivan Mitic commented on YARN-493:
---------------------------------
Thanks Chris, this looks really good!
Two really minor comments below, otherwise, +1 from me
1. Would it make sense to extract badSymlink with quoting to a platform
dependent constant and still use the new Shell util?
{code}
if (Shell.WINDOWS) {
commands.add("cmd");
commands.add("/c");
commands.add("\"" + badSymlink + "\"");
} else {
commands.add("/bin/sh ./\\\"" + badSymlink + "\\\"");
}
{code}
2. (non-binding) I was thinking whether we can come up with better (more
intuitive) names for getScriptName/getScriptFile? Maybe appendScriptExtension?
> NodeManager job control logic flaws on Windows
> ----------------------------------------------
>
> Key: YARN-493
> URL: https://issues.apache.org/jira/browse/YARN-493
> Project: Hadoop YARN
> Issue Type: Bug
> Components: nodemanager
> Reporter: Chris Nauroth
> Assignee: Chris Nauroth
> Fix For: 3.0.0
>
> Attachments: YARN-493.1.patch, YARN-493.2.patch
>
>
> Both product and test code contain some platform-specific assumptions, such
> as availability of bash for executing a command in a container and signals to
> check existence of a process and terminate it.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
