[ https://issues.apache.org/jira/browse/YARN-447?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13618447#comment-13618447 ]
Arun C Murthy commented on YARN-447: ------------------------------------ +1, lgtm! > applicationComparator improvement for CS > ---------------------------------------- > > Key: YARN-447 > URL: https://issues.apache.org/jira/browse/YARN-447 > Project: Hadoop YARN > Issue Type: Improvement > Components: scheduler > Affects Versions: 2.0.3-alpha > Reporter: nemon lou > Assignee: nemon lou > Priority: Minor > Attachments: YARN-447-trunk.patch, YARN-447-trunk.patch, > YARN-447-trunk.patch > > > Now the compare code is : > return a1.getApplicationId().getId() - a2.getApplicationId().getId(); > Will be replaced with : > return a1.getApplicationId().compareTo(a2.getApplicationId()); > This will bring some benefits: > 1,leave applicationId compare logic to ApplicationId class; > 2,In future's HA mode,cluster time stamp may change,ApplicationId class > already takes care of this condition. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira