[
https://issues.apache.org/jira/browse/YARN-193?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13619111#comment-13619111
]
Zhijie Shen commented on YARN-193:
----------------------------------
@Bikas
{quote}
This and others like it are back-incompatible but might be ok since we are
still in alpha
{quote}
It's confusing the name and the default use core and vcore respectively.
Therefore, as we're still in the alpha stage, IMHO, we'd better make them
consistent.
{quote}
It should be disabled. Same for other places.
{quote}
Will be fixed.
{quote}
This and other places, a LOG in the catch would be good.
{quote}
Log will be added.
{quote}
Incorrect log message.
{quote}
Log message will be fixed.
{quote}
Also, in this method, why are we throwing an exception in the inner block and
catching it in the outer block. Why is the inner try catch needed (instead of
catching the exception in the outer catch)?
{quote}
This is because InvalidResourceRequestException extends YarnException, while
the outer block only catches the IOException, which YarnRemoteException extends.
{quote}
On the same note, why can this validation not be done in ClientRMService just
like its been done in ApplicationMasterService?
{quote}
This is because the validation is done in submitApplication
{quote}
Where are we testing that normalize is being set to the next higher multiple of
min but not more than the max (for DRF case)? OR that checking against max is
disabled by setting MAX allowed to -1. I am sorry if I have missed it.
{quote}
There's one test in TestSchedulerUtils#testNormalizeRequest for the former
case, while I'll had tests for the latter case and
ResourceManager#validateConfigs as well.
> Scheduler.normalizeRequest does not account for allocation requests that
> exceed maximumAllocation limits
> ---------------------------------------------------------------------------------------------------------
>
> Key: YARN-193
> URL: https://issues.apache.org/jira/browse/YARN-193
> Project: Hadoop YARN
> Issue Type: Bug
> Components: resourcemanager
> Affects Versions: 2.0.2-alpha, 3.0.0
> Reporter: Hitesh Shah
> Assignee: Zhijie Shen
> Attachments: MR-3796.1.patch, MR-3796.2.patch, MR-3796.3.patch,
> MR-3796.wip.patch, YARN-193.4.patch, YARN-193.5.patch, YARN-193.6.patch,
> YARN-193.7.patch, YARN-193.8.patch, YARN-193.9.patch
>
>
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
