[ https://issues.apache.org/jira/browse/YARN-555?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13625236#comment-13625236 ]
Harsh J commented on YARN-555: ------------------------------ If I do: {code} Map<String, LocalResource> localResources = new HashMap<String, LocalResource>(); localResources.put("node-ring-app-master.jar", appMasterJarResource); appContext.getAMContainerSpec().setLocalResources(localResources); {code} Things work fine. If I instead do the more "extending" form: {code} Map<String, LocalResource> localResources = appContext.getAMContainerSpec().getLocalResources(); localResources.put("node-ring-app-master.jar", appMasterJarResource); appContext.getAMContainerSpec().setLocalResources(localResources); {code} Then the mutations don't stick. Wonder if this is somehow a Java oddity? > ContainerLaunchContext is buggy when it comes to setter methods on a new > instance > --------------------------------------------------------------------------------- > > Key: YARN-555 > URL: https://issues.apache.org/jira/browse/YARN-555 > Project: Hadoop YARN > Issue Type: Bug > Components: api > Affects Versions: 2.0.3-alpha > Reporter: Harsh J > Priority: Minor > > If you look at the API of ContainerLaunchContext, its got setter methods, > such as for setResource, setCommands, etc…: > http://hadoop.apache.org/docs/current/api/org/apache/hadoop/yarn/api/records/ContainerLaunchContext.html#setCommands(java.util.List) > However, there's certain things broken in its use here that am trying to > understand. Let me explain with some code context: > 1. I initialize a proper CLC for an ApplicationSubmissionContext (appContext). > {code} > ContainerLaunchContext appMasterLaunchContext = > Records.newRecord(ContainerLaunchContext.class); > appContext.setAMContainerSpec(appMasterLaunchContext); > {code} > 2. I create a resource request of 130 MB, as applicationMasterResource, and > try to set it into the CLC via: > {code} > appContext.getAMContainerSpec().setResource(applicationMasterResource); > {code} > 3. This works OK. If I query it back now, it returns 130 for a > {{getMemory()}} call. > 4. So I attempt to do the same with setCommands/setEnvironment/etc., all of > which fail to mutate cause the check in CLC's implementation class disregards > whatever I try to set for some reason. > Edit: It seems like the issue is that when I do a > appContext.getAMContainerSpec().getLocalResources() or similar call to get > existing initialized data structures to populate further on, what I really > get underneath is a silently non-mutative data structure that I can call .put > or .add on, but it won't really reflect it. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira