[ https://issues.apache.org/jira/browse/YARN-457?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13628384#comment-13628384 ]
Xuan Gong commented on YARN-457: -------------------------------- Comments: I think if the updatedNodes == null, just simply do return. if updatedNodes is not null, then do initialization and add updatedNodes. What this patch shows, if updatedNodes(input) is null, simply do the initialization, then delete all of the updatedNodes which are added in the initialization. I do not think this is the right way to do the setter > Setting updated nodes from null to null causes NPE in AllocateResponsePBImpl > ---------------------------------------------------------------------------- > > Key: YARN-457 > URL: https://issues.apache.org/jira/browse/YARN-457 > Project: Hadoop YARN > Issue Type: Sub-task > Components: api > Affects Versions: 2.0.3-alpha > Reporter: Sandy Ryza > Assignee: Kenji Kikushima > Priority: Minor > Labels: Newbie > Attachments: YARN-457-2.patch, YARN-457.patch > > > {code} > if (updatedNodes == null) { > this.updatedNodes.clear(); > return; > } > {code} > If updatedNodes is already null, a NullPointerException is thrown. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira