[ 
https://issues.apache.org/jira/browse/YARN-547?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13630766#comment-13630766
 ] 

Hadoop QA commented on YARN-547:
--------------------------------

{color:red}-1 overall{color}.  Here are the results of testing the latest 
attachment 
  
http://issues.apache.org/jira/secure/attachment/12578544/yarn-547-20130412.patch
  against trunk revision .

    {color:green}+1 @author{color}.  The patch does not contain any @author 
tags.

    {color:green}+1 tests included{color}.  The patch appears to include 1 new 
or modified test files.

    {color:green}+1 javac{color}.  The applied patch does not increase the 
total number of javac compiler warnings.

    {color:green}+1 javadoc{color}.  The javadoc tool did not generate any 
warning messages.

    {color:green}+1 eclipse:eclipse{color}.  The patch built with 
eclipse:eclipse.

    {color:green}+1 findbugs{color}.  The patch does not introduce any new 
Findbugs (version 1.3.9) warnings.

    {color:green}+1 release audit{color}.  The applied patch does not increase 
the total number of release audit warnings.

    {color:red}-1 core tests{color}.  The patch failed these unit tests in 
hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-nodemanager:

                  
org.apache.hadoop.yarn.server.nodemanager.containermanager.localizer.TestLocalResourcesTrackerImpl
                  
org.apache.hadoop.yarn.server.nodemanager.containermanager.localizer.TestLocalizedResource

    {color:green}+1 contrib tests{color}.  The patch passed contrib unit tests.

Test results: 
https://builds.apache.org/job/PreCommit-YARN-Build/731//testReport/
Console output: https://builds.apache.org/job/PreCommit-YARN-Build/731//console

This message is automatically generated.
                
> New resource localization is tried even when Localized Resource is in 
> DOWNLOADING state
> ---------------------------------------------------------------------------------------
>
>                 Key: YARN-547
>                 URL: https://issues.apache.org/jira/browse/YARN-547
>             Project: Hadoop YARN
>          Issue Type: Sub-task
>            Reporter: Omkar Vinit Joshi
>            Assignee: Omkar Vinit Joshi
>         Attachments: yarn-547-20130411.1.patch, yarn-547-20130411.patch, 
> yarn-547-20130412.patch
>
>
> At present when multiple containers try to request a localized resource 
> 1) If the resource is not present then first it is created and Resource 
> Localization starts ( LocalizedResource is in DOWNLOADING state)
> 2) Now if in this state multiple ResourceRequestEvents come in then 
> ResourceLocalizationEvents are fired for all of them.
> Most of the times it is not resulting into a duplicate resource download but 
> there is a race condition present there. 
> Location : ResourceLocalizationService.addResource .. addition of the request 
> into "attempts" in case of an event already exists.
> The root cause for this is the presence of FetchResourceTransition on 
> receiving ResourceRequestEvent in DOWNLOADING state.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

Reply via email to