[
https://issues.apache.org/jira/browse/YARN-513?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13644176#comment-13644176
]
Bikas Saha commented on YARN-513:
---------------------------------
Overall approach looks good. We could try to reuse existing RetryPolicy etc
inside RMClient as long as we maintain the RMClient abstraction. Detailed
review comments after we decide on what we want to resuse.
Are we not missing an RMClient.disconnect()? This one would internally stop the
proxy?
Looks like NMStatusUpdater.getRMClient() can be removed because
createRMClient() is being overridden by all tests.
Why are we throwing YARNException?
Is any test explicitly testing the new code with a real RM? How about manually
doing it?
> Verify all clients will wait for RM to restart
> ----------------------------------------------
>
> Key: YARN-513
> URL: https://issues.apache.org/jira/browse/YARN-513
> Project: Hadoop YARN
> Issue Type: Sub-task
> Components: resourcemanager
> Reporter: Bikas Saha
> Assignee: Xuan Gong
> Attachments: YARN-513.1.patch, YARN-513.2.patch
>
>
> When the RM is restarting, the NM, AM and Clients should wait for some time
> for the RM to come back up.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
