[ 
https://issues.apache.org/jira/browse/YARN-506?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13644215#comment-13644215
 ] 

Ivan Mitic commented on YARN-506:
---------------------------------

Thanks Chris for the review!

bq. I still saw a failure in TestNodeHealthService after applying this patch. 
Ivan, did this patch fix that test for you?
Nope, the scope of the patch is to move to new common utils, and the test fails 
for a different reason. I validated that 
TestNodeHealthService#testNodeHealthScriptShouldRun succeeds with the patch 
(test revokes the execute permission on the script and validates that the 
script cannot run).
                
> Move to common utils FileUtil#setReadable/Writable/Executable and 
> FileUtil#canRead/Write/Execute
> ------------------------------------------------------------------------------------------------
>
>                 Key: YARN-506
>                 URL: https://issues.apache.org/jira/browse/YARN-506
>             Project: Hadoop YARN
>          Issue Type: Bug
>    Affects Versions: 3.0.0
>            Reporter: Ivan Mitic
>            Assignee: Ivan Mitic
>         Attachments: YARN-506.commonfileutils.2.patch, 
> YARN-506.commonfileutils.patch
>
>
> Move to common utils described in HADOOP-9413 that work well cross-platform.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

Reply via email to