[ 
https://issues.apache.org/jira/browse/YARN-45?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13650246#comment-13650246
 ] 

Bikas Saha commented on YARN-45:
--------------------------------

Overall, the approach looks good.

Would be great if you could add a version number to your patches.

The javadoc is trying to help by giving more information. However, if I think 
from the perspective of someone who doesnt understand YARN, RM, scheduling and 
preemption, the javadoc would be hard to understand. Can we re-write this wrt 
perspective of the user of the API. How are they supposed to interpret this 
data. What needs to be done by them.
{code}
+  /**
+   * Get the description of containers owned by the AM, but requested back by
+   * the cluster. Note that the RM may have an inconsistent view of the
+   * resources owned by the AM. The AM may elect to ignore some or all 
requests.
+   *
+   * The message is a snapshot of the resources the RM wants back from the AM.
+   * While demand persists, the RM will sustain its ask. Resources requested
+   * consistently over some duration may be forcibly killed by the RM.
{code}

In general, the javadocs and class names are a little hard for me to 
understand, but it just might be me :)
                
> Scheduler feedback to AM to release containers
> ----------------------------------------------
>
>                 Key: YARN-45
>                 URL: https://issues.apache.org/jira/browse/YARN-45
>             Project: Hadoop YARN
>          Issue Type: Sub-task
>          Components: resourcemanager
>            Reporter: Chris Douglas
>            Assignee: Carlo Curino
>         Attachments: YARN-45.patch, YARN-45.patch, YARN-45.patch, 
> YARN-45.patch, YARN-45.patch, YARN-45.patch, 
> YARN-45_summary_of_alternatives.pdf
>
>
> The ResourceManager strikes a balance between cluster utilization and strict 
> enforcement of resource invariants in the cluster. Individual allocations of 
> containers must be reclaimed- or reserved- to restore the global invariants 
> when cluster load shifts. In some cases, the ApplicationMaster can respond to 
> fluctuations in resource availability without losing the work already 
> completed by that task (MAPREDUCE-4584). Supplying it with this information 
> would be helpful for overall cluster utilization [1]. To this end, we want to 
> establish a protocol for the RM to ask the AM to release containers.
> [1] http://research.yahoo.com/files/yl-2012-003.pdf

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

Reply via email to