[ 
https://issues.apache.org/jira/browse/YARN-642?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13655119#comment-13655119
 ] 

Vinod Kumar Vavilapalli commented on YARN-642:
----------------------------------------------

bq. With Tucu's suggestion of an "all" option, though, maybe this isn't 
necessary, so I can take it out.
Yes, we should just do this.

bq. The Java/RPC API (ClientRMProtocol#getClusterNodes) returns the list of all 
active nodes, which includes unhealthy nodes. It seems confusing to me to have 
them return different things. Thoughts?
Good point. I can rationalize what others said on MAPREDUCE-3760. When one goes 
to the default nodes UI, you are used to seeing active/good nodes since 
Hadoop-1. I think what we should do is
 - by default show only active nodes
 - if given a state, show the corresponding nodes
 - and a special "all" to show all nodes
Thoughs?

And clearly, we need to fix the RPC impl to accomodate the above, accepting 
states etc. Can you file a separate ticket for that?
                
> Fix up /nodes REST API to have 1 param and be consistent with the Java API
> --------------------------------------------------------------------------
>
>                 Key: YARN-642
>                 URL: https://issues.apache.org/jira/browse/YARN-642
>             Project: Hadoop YARN
>          Issue Type: Bug
>          Components: api, resourcemanager
>    Affects Versions: 2.0.4-alpha
>            Reporter: Sandy Ryza
>            Assignee: Sandy Ryza
>              Labels: incompatible
>         Attachments: YARN-642-1.patch, YARN-642.patch
>
>
> The code behind the /nodes RM REST API is unnecessarily muddled, logs the 
> same misspelled INFO message repeatedly, and does not return unhealthy nodes, 
> even when asked.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

Reply via email to