[ 
https://issues.apache.org/jira/browse/YARN-628?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13660115#comment-13660115
 ] 

Bikas Saha commented on YARN-628:
---------------------------------

It would have been great if we could have not had this pattern everywhere. I am 
guessing the return null is there because the compiler was complaining? And the 
return null is basically dead code right?
{code}
     } catch (ServiceException e) {
-      throw RPCUtil.unwrapAndThrowException(e);
+      RPCUtil.unwrapAndThrowException(e);
+      return null;
     }
{code}
                
> Fix YarnException unwrapping
> ----------------------------
>
>                 Key: YARN-628
>                 URL: https://issues.apache.org/jira/browse/YARN-628
>             Project: Hadoop YARN
>          Issue Type: Sub-task
>    Affects Versions: 2.0.4-alpha
>            Reporter: Siddharth Seth
>            Assignee: Siddharth Seth
>             Fix For: 2.0.5-beta
>
>         Attachments: YARN-628.txt, YARN-628.txt, YARN-628.txt, YARN-628.txt.2
>
>
> Unwrapping of YarnRemoteExceptions (currently in YarnRemoteExceptionPBImpl, 
> RPCUtil post YARN-625) is broken, and often ends up throwin 
> UndeclaredThrowableException. This needs to be fixed.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

Reply via email to