[ 
https://issues.apache.org/jira/browse/YARN-422?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Zhijie Shen updated YARN-422:
-----------------------------

    Attachment: YARN-422.8.patch

Thank Vinod for the comments! I've addressed most of them. WRT the question:
bq. What if a container is already stopped is stopped again?
In the updated patch, stopping a container when it is not started or scheduled 
to start will throw the exception immediately.

bq. In fact, you can use a simple state-machine and explicit transitions 
instead of the field states and the conditional logic.

State machine is good idea, but it seems not to be a quick solution. How about 
we confirming the API, and improving the implementation later?
                
> Add NM client library
> ---------------------
>
>                 Key: YARN-422
>                 URL: https://issues.apache.org/jira/browse/YARN-422
>             Project: Hadoop YARN
>          Issue Type: Sub-task
>            Reporter: Bikas Saha
>            Assignee: Zhijie Shen
>         Attachments: AMNMClient_Defination.txt, 
> AMNMClient_Definition_Updated_With_Tests.txt, proposal_v1.pdf, 
> YARN-422.1.patch, YARN-422.2.patch, YARN-422.3.patch, YARN-422.4.patch, 
> YARN-422.5.patch, YARN-422.6.patch, YARN-422.8.patch
>
>
> Create a simple wrapper over the ContainerManager protocol to provide hide 
> the details of the protocol implementation.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

Reply via email to