[ 
https://issues.apache.org/jira/browse/YARN-753?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13674105#comment-13674105
 ] 

Vinod Kumar Vavilapalli commented on YARN-753:
----------------------------------------------

Looked at the patch. Mostly looks good except the following:
 - GetAllApplicationsResponse's factory isn't setting the appReports field.
 - PreemptionResourceRequestPBImpl should have equals/hashCode etc.
                
> Add individual factory method for api protocol records
> ------------------------------------------------------
>
>                 Key: YARN-753
>                 URL: https://issues.apache.org/jira/browse/YARN-753
>             Project: Hadoop YARN
>          Issue Type: Bug
>            Reporter: Jian He
>            Assignee: Jian He
>         Attachments: YARN-753.1.patch
>
>


--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

Reply via email to