[ 
https://issues.apache.org/jira/browse/YARN-773?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13677906#comment-13677906
 ] 

Steve Loughran commented on YARN-773:
-------------------------------------

# Given the grief I had with the last exception rebasing, I'd clearly like to 
get my -117 patch in first.
# That failing test is one that I'd already patched there, as it was too 
brittle against exception time and location of the test; as wrapping of 
exceptions changed it would break. The patched version looks for the string on 
a contains, not an equals

{code}
      if(!e.getMessage().contains(errMessage)) {
        throw e;
      }
{code}

Even those tests are brittle against the error text changing -the text should 
be moved to constant strings in the source files and referenced by the tests

                
> Move YarnRuntimeException from package api.yarn to api.yarn.exceptions
> ----------------------------------------------------------------------
>
>                 Key: YARN-773
>                 URL: https://issues.apache.org/jira/browse/YARN-773
>             Project: Hadoop YARN
>          Issue Type: Sub-task
>            Reporter: Jian He
>            Assignee: Jian He
>         Attachments: YARN-773.patch
>
>


--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

Reply via email to