[ https://issues.apache.org/jira/browse/YARN-5802?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15628578#comment-15628578 ]
Bibin A Chundatt commented on YARN-5802: ---------------------------------------- Thank you [~sunilg] for review comment. Update patch handling all review comments.. > Application priority updates add pending apps to running ordering policy > ------------------------------------------------------------------------ > > Key: YARN-5802 > URL: https://issues.apache.org/jira/browse/YARN-5802 > Project: Hadoop YARN > Issue Type: Sub-task > Reporter: Bibin A Chundatt > Assignee: Bibin A Chundatt > Priority: Critical > Attachments: YARN-5802.0001.patch, YARN-5802.0002.patch, > YARN-5802.0003.patch, YARN-5802.0004.patch, YARN-5802.0005.patch, > YARN-5802.0006.patch > > > {{LeafQueue#updateApplicationPriority}} > {code} > getOrderingPolicy().removeSchedulableEntity(attempt); > // Update new priority in SchedulerApplication > attempt.setPriority(newAppPriority); > getOrderingPolicy().addSchedulableEntity(attempt); > {code} > We should add again to ordering policy only when attempt available in first > case.Else during application attempt removal will try to iterate on killed > application still available in pending Ordering policy.Which can cause RM to > crash. -- This message was sent by Atlassian JIRA (v6.3.4#6332) --------------------------------------------------------------------- To unsubscribe, e-mail: yarn-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: yarn-issues-h...@hadoop.apache.org