[ 
https://issues.apache.org/jira/browse/YARN-5811?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15629067#comment-15629067
 ] 

Daniel Templeton commented on YARN-5811:
----------------------------------------

[~bolshakov.de...@gmail.com], thanks for updating the patch.

The inner method pattern is a common one in YARN.  I don't disagree that it 
seems superfluous, but I would rather not rip it out here in an unrelated 
patch.  I you feel strongly about taking it out, let's open another JIRA to 
discuss it.

> ConfigurationProvider must implement Closeable interface
> --------------------------------------------------------
>
>                 Key: YARN-5811
>                 URL: https://issues.apache.org/jira/browse/YARN-5811
>             Project: Hadoop YARN
>          Issue Type: Improvement
>          Components: yarn
>            Reporter: Denis Bolshakov
>            Priority: Minor
>              Labels: newbie
>         Attachments: YARN-5811.1.patch, YARN-5811.3.patch, YARN-5811.5.patch, 
> YARN-5811.6.patch
>
>
> ConfigurationProvider declares close method, it would be so nice if the class 
> implements Closeable interface allowing to use `try with resources`



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

---------------------------------------------------------------------
To unsubscribe, e-mail: yarn-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: yarn-issues-h...@hadoop.apache.org

Reply via email to