[ https://issues.apache.org/jira/browse/YARN-5377?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15634701#comment-15634701 ]
Konstantinos Karanasos edited comment on YARN-5377 at 11/3/16 11:59 PM: ------------------------------------------------------------------------ The problem with the test is that the container was moving fast from the DONE to the CONTAINER_CLEANUP_AFTER_KILL state, and the DONE state was not observed by the {{waitForNMContainerState}} method of the {{BaseContainerManagerTest}}. I added a new {{waitForNMContainerState}} method that takes as input a list of final container states, instead of a single one like before. When any of the states of this list is reached, the {{waitForNMContainerState}} exits successfully. was (Author: kkaranasos): The problem with the test is that the container was moving fast from the DONE to the CONTAINER_CLEANUP_AFTER_KILL, and the DONE state was not observed by the {{waitForNMContainerState}} method of the {{BaseContainerManagerTest}}. I added a new {{waitForNMContainerState}} method that takes as input a list of final container states, instead of a single one like before. When any of the states of this list is reached, the {{waitForNMContainerState}} exits successfully. > TestQueuingContainerManager.testKillMultipleOpportunisticContainers fails in > trunk > ---------------------------------------------------------------------------------- > > Key: YARN-5377 > URL: https://issues.apache.org/jira/browse/YARN-5377 > Project: Hadoop YARN > Issue Type: Bug > Reporter: Rohith Sharma K S > Assignee: Konstantinos Karanasos > Attachments: YARN-5377.001.patch > > > Test case fails jenkin build > [link|https://builds.apache.org/job/PreCommit-YARN-Build/12228/artifact/patchprocess/patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-nodemanager.txt] > {noformat} > Tests run: 6, Failures: 1, Errors: 0, Skipped: 0, Time elapsed: 134.586 sec > <<< FAILURE! - in > org.apache.hadoop.yarn.server.nodemanager.containermanager.queuing.TestQueuingContainerManager > testKillMultipleOpportunisticContainers(org.apache.hadoop.yarn.server.nodemanager.containermanager.queuing.TestQueuingContainerManager) > Time elapsed: 32.134 sec <<< FAILURE! > java.lang.AssertionError: ContainerState is not correct (timedout) > expected:<DONE> but was:<CONTAINER_CLEANEDUP_AFTER_KILL> > at org.junit.Assert.fail(Assert.java:88) > at org.junit.Assert.failNotEquals(Assert.java:743) > at org.junit.Assert.assertEquals(Assert.java:118) > at > org.apache.hadoop.yarn.server.nodemanager.containermanager.BaseContainerManagerTest.waitForNMContainerState(BaseContainerManagerTest.java:363) > at > org.apache.hadoop.yarn.server.nodemanager.containermanager.queuing.TestQueuingContainerManager.testKillMultipleOpportunisticContainers(TestQueuingContainerManager.java:470) > {noformat} -- This message was sent by Atlassian JIRA (v6.3.4#6332) --------------------------------------------------------------------- To unsubscribe, e-mail: yarn-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: yarn-issues-h...@hadoop.apache.org