[
https://issues.apache.org/jira/browse/YARN-4355?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15641889#comment-15641889
]
Naganarasimha G R commented on YARN-4355:
-----------------------------------------
Thanks [~varun_saxena] for the patch,
I have some doubts for avoiding race @ ResourceLocalizationService, ln no 1119.
# If cleanup has happened then are there chances of having pending
{{LocalizerResourceRequestEvent}} in *LocalizerRunner* ?
# Also cant we pass the same tracker instance to {{getPathForLocalization}}
from LocalizerRunner.processHeartbeat ?
Few trivial nits:
# TestResourceLocalizationService, ln no 1543 : no need to create a new array
list when we are using {{Arrays.asList(req1, req2)}}
# TestResourceLocalizationService, ln no 1581 : may be we can join the line
below line as it doesn't exceed 80 chars.
> NPE while processing localizer heartbeat
> ----------------------------------------
>
> Key: YARN-4355
> URL: https://issues.apache.org/jira/browse/YARN-4355
> Project: Hadoop YARN
> Issue Type: Bug
> Components: nodemanager
> Affects Versions: 2.7.2
> Reporter: Jason Lowe
> Assignee: Varun Saxena
> Attachments: YARN-4355.01.patch, YARN-4355.02.patch,
> YARN-4355.03.patch, YARN-4355.04.patch
>
>
> While analyzing YARN-4354 I noticed a nodemanager was getting NPEs while
> processing a private localizer heartbeat. I think there's a race where we
> can cleanup resources for an application and therefore remove the app local
> resource tracker just as we are trying to handle the localizer heartbeat.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
---------------------------------------------------------------------
To unsubscribe, e-mail: yarn-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: yarn-issues-h...@hadoop.apache.org
