[
https://issues.apache.org/jira/browse/YARN-5783?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15645749#comment-15645749
]
Daniel Templeton commented on YARN-5783:
----------------------------------------
According to your Stackoverflow link, the correct implementation is:
{code}
@Override
public int hashCode() {
return Objects.hash(getApplicationAttemptId());
}
{code}
I take issue with even that approach, though. If the only thing that makes the
hash code different between two attempts is the hash code of the attempt ID
(which is sane and makes logical sense), then the {{hashCode()}} method should
return {{getApplicationAttemptId().hashCode()}}.
Other than that, I'm happy with the latest patch.
> Verify applications are identified starved
> ------------------------------------------
>
> Key: YARN-5783
> URL: https://issues.apache.org/jira/browse/YARN-5783
> Project: Hadoop YARN
> Issue Type: Sub-task
> Components: fairscheduler
> Affects Versions: 2.8.0
> Reporter: Karthik Kambatla
> Assignee: Karthik Kambatla
> Labels: oct16-medium
> Attachments: yarn-5783.YARN-4752.1.patch,
> yarn-5783.YARN-4752.2.patch, yarn-5783.YARN-4752.3.patch,
> yarn-5783.YARN-4752.4.patch, yarn-5783.YARN-4752.5.patch,
> yarn-5783.YARN-4752.6.patch
>
>
> JIRA to track unit tests to verify the identification of starved
> applications. An application should be marked starved only when:
> # Cluster allocation is over the configured threshold for preemption.
> # Preemption is enabled for a queue and any of the following:
> ## The queue is under its minshare for longer than minsharePreemptionTimeout
> ## One of the queue’s applications is under its fairshare for longer than
> fairsharePreemptionTimeout.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
---------------------------------------------------------------------
To unsubscribe, e-mail: yarn-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: yarn-issues-h...@hadoop.apache.org
