[ https://issues.apache.org/jira/browse/YARN-5820?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15646401#comment-15646401 ]
Naganarasimha G R commented on YARN-5820: ----------------------------------------- Hi [~grant.sohn], Actually to say there are multiple styles of the commands which exists, but for YARN we usually try to define each option which is not followed in Hdfs commands (lists in each line for each sub command but no definition of it ). So i am ok with the existing approach but do agree with [~grant.sohn] on why just {{<NodeId>}} in new line? [~ajithshetty], if you see any test case failure for it can we correct the test case instead ? > yarn node CLI help should be clearer > ------------------------------------ > > Key: YARN-5820 > URL: https://issues.apache.org/jira/browse/YARN-5820 > Project: Hadoop YARN > Issue Type: Bug > Components: client > Affects Versions: 2.6.0 > Reporter: Grant Sohn > Assignee: Ajith S > Priority: Trivial > Attachments: YARN-5820.01.patch, YARN-5820.02.patch, > YARN-5820.03.patch, YARN-5820.04.patch > > > Current message is: > {noformat} > usage: node > -all Works with -list to list all nodes. > -list List all running nodes. Supports optional use of > -states to filter nodes based on node state, all -all > to list all nodes. > -states <States> Works with -list to filter nodes based on input > comma-separated list of node states. > -status <NodeId> Prints the status report of the node. > {noformat} > It should be either this: > {noformat} > usage: yarn node [-list [-states <States>|-all] | -status <NodeId>] > -all Works with -list to list all nodes. > -list List all running nodes. Supports optional use of > -states to filter nodes based on node state, all -all > to list all nodes. > -states <States> Works with -list to filter nodes based on input > comma-separated list of node states. > -status <NodeId> Prints the status report of the node. > {noformat} > or that. > {noformat} > usage: yarn node -list [-states <States>|-all] > yarn node -status <NodeId> > -all Works with -list to list all nodes. > -list List all running nodes. Supports optional use of > -states to filter nodes based on node state, all -all > to list all nodes. > -states <States> Works with -list to filter nodes based on input > comma-separated list of node states. > -status <NodeId> Prints the status report of the node. > {noformat} > The latter is the least ambiguous. -- This message was sent by Atlassian JIRA (v6.3.4#6332) --------------------------------------------------------------------- To unsubscribe, e-mail: yarn-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: yarn-issues-h...@hadoop.apache.org