[
https://issues.apache.org/jira/browse/YARN-5819?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15646534#comment-15646534
]
Karthik Kambatla commented on YARN-5819:
----------------------------------------
Thanks for the prompt and thorough first pass, [~templedf]. The second patch
captures most of your suggestions except a couple.
bq. Maybe I'm old, but I don't like non-incremental for loops:
Is there a good reason to not use for-loops here? While I am not particular on
for/while loop, readability is subjective. I actually find the for loop much
more readable than the while loop and it avoids accidentally missing the queue
increment.
bq. There's an extra space after the cast in setupCluster()
The [Oracle/Sun code
conventions|http://www.oracle.com/technetwork/java/codeconventions-150003.pdf]
recommend a blank space after the cast.
> Verify fairshare and minshare preemption
> ----------------------------------------
>
> Key: YARN-5819
> URL: https://issues.apache.org/jira/browse/YARN-5819
> Project: Hadoop YARN
> Issue Type: Sub-task
> Components: fairscheduler
> Affects Versions: 2.9.0
> Reporter: Karthik Kambatla
> Assignee: Karthik Kambatla
> Attachments: yarn-5819.YARN-4752.1.patch, yarn-5819.YARN-4752.2.patch
>
>
> JIRA to track the unit test(s) verifying both fairshare and minshare
> preemption. The tests should verify:
> # preemption within a single leaf queue
> # preemption between sibling leaf queues
> # preemption between non-sibling leaf queues
> # {{allowPreemption = false}} should disallow preemption from a queue
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
---------------------------------------------------------------------
To unsubscribe, e-mail: yarn-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: yarn-issues-h...@hadoop.apache.org
