[ https://issues.apache.org/jira/browse/YARN-5834?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15653391#comment-15653391 ]
Chang Li commented on YARN-5834: -------------------------------- Thanks for reporting. Yes it's meant to be nmRmConnectionWaitMs. Provide branch-2 patch since this test does not exist in trunk > TestNodeStatusUpdater.testNMRMConnectionConf compares nodemanager wait time > to the incorrect value > -------------------------------------------------------------------------------------------------- > > Key: YARN-5834 > URL: https://issues.apache.org/jira/browse/YARN-5834 > Project: Hadoop YARN > Issue Type: Bug > Reporter: Miklos Szegedi > Assignee: Chang Li > Priority: Minor > Attachments: YARN-5834-branch-2.001.patch > > > The function is TestNodeStatusUpdater#testNMRMConnectionConf() > I believe the connectionWaitMs references below were meant to be > nmRmConnectionWaitMs. > {code} > conf.setLong(YarnConfiguration.NM_RESOURCEMANAGER_CONNECT_MAX_WAIT_MS, > nmRmConnectionWaitMs); > conf.setLong(YarnConfiguration.RESOURCEMANAGER_CONNECT_MAX_WAIT_MS, > connectionWaitMs); > ... > long t = System.currentTimeMillis(); > long duration = t - waitStartTime; > boolean waitTimeValid = (duration >= nmRmConnectionWaitMs) && > (duration < (*connectionWaitMs* + delta)); > if(!waitTimeValid) { > // throw exception if NM doesn't retry long enough > throw new Exception("NM should have tried re-connecting to RM during > " + > "period of at least " + *connectionWaitMs* + " ms, but " + > "stopped retrying within " + (*connectionWaitMs* + delta) + > " ms: " + e, e); > } > {code} -- This message was sent by Atlassian JIRA (v6.3.4#6332) --------------------------------------------------------------------- To unsubscribe, e-mail: yarn-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: yarn-issues-h...@hadoop.apache.org