[
https://issues.apache.org/jira/browse/YARN-5600?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15655703#comment-15655703
]
Tan, Wangda commented on YARN-5600:
-----------------------------------
This is a very useful feature without any doubt, thanks
[~miklos.szeg...@cloudera.com] for working on this JIRA and thanks reviews from
[~Naganarasimha] / [~templedf] for reviewing the patch.
Apologize for my very late review, I only looked at API of the patch: Have you
ever considered the other approach, which we can turn on debug-delay-sec by
passing a pre-defined environment. The biggest benefit is, we don't need to
update most applications to use this feature, for example, MR/Spark support
specify environment. Making changes to all major applications to use this
feature sounds like a big task.
As an example LinuxDockerContainerExecutor uses the approach which specify
configurations by passing env var.
And in addition, it will be better to have a global max-debug-delay-sec in
yarn-site (which could be MAX_INT by default), considering disk space and
security, we may want application occupy disk beyond some specified time.
+ [~djp]
> Add a parameter to ContainerLaunchContext to emulate
> yarn.nodemanager.delete.debug-delay-sec on a per-application basis
> -----------------------------------------------------------------------------------------------------------------------
>
> Key: YARN-5600
> URL: https://issues.apache.org/jira/browse/YARN-5600
> Project: Hadoop YARN
> Issue Type: Improvement
> Components: nodemanager
> Affects Versions: 3.0.0-alpha1
> Reporter: Daniel Templeton
> Assignee: Miklos Szegedi
> Labels: oct16-medium
> Attachments: YARN-5600.000.patch, YARN-5600.001.patch,
> YARN-5600.002.patch, YARN-5600.003.patch, YARN-5600.004.patch,
> YARN-5600.005.patch, YARN-5600.006.patch, YARN-5600.007.patch
>
>
> To make debugging application launch failures simpler, I'd like to add a
> parameter to the CLC to allow an application owner to request delayed
> deletion of the application's launch artifacts.
> This JIRA solves largely the same problem as YARN-5599, but for cases where
> ATS is not in use, e.g. branch-2.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
---------------------------------------------------------------------
To unsubscribe, e-mail: yarn-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: yarn-issues-h...@hadoop.apache.org
