[
https://issues.apache.org/jira/browse/YARN-5885?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15672032#comment-15672032
]
Daniel Templeton commented on YARN-5885:
----------------------------------------
I took a closer look and found more nits, but nothing major.
* In {{TestFSAppStarvation}}, {{queues}} should be {{QUEUES}}.
* In {{testPreemptionEnabled()}}, since you updated the {{assertEquals()}}
message, can you please also move the {{+}} to the start of the next line?
* Comment on line 194 should probably be different from the comment on 184;
otherwise the information content is low.
* {{FSPreemptionThread. identifyContainersToPreempt()}} still has a period
after the {{@return}} summary.
* The javadoc for {{FSAppAttempt.getStarvation()}} still should end with a
period.
* Javadoc summary on {{FSLeafQueue.isStarved()}} and {{isStarvedForFairShare}}
is wrong. Copy-paste error.
* In {{TestQueueManagerRealScheduler.writeAllocFile()}}, any reason why those
three prints don't get newlines?
* Looks to me like {{testBackwardsCompatiblePreemptionConfiguration()}} could
reuse {{writeAllocFile()}} rather than duplicating it.
* You should deal with the line length for
{{testBackwardsCompatiblePreemptionConfiguration()}}'s signature.
> Cleanup YARN-4752 for merge
> ---------------------------
>
> Key: YARN-5885
> URL: https://issues.apache.org/jira/browse/YARN-5885
> Project: Hadoop YARN
> Issue Type: Sub-task
> Components: fairscheduler
> Reporter: Karthik Kambatla
> Assignee: Karthik Kambatla
> Attachments: yarn-5885.1.patch, yarn-5885.2.patch,
> yarn-5885.YARN-4752.2.patch, yarn-5885.YARN-4752.3.patch
>
>
> JIRA to track changes necessary for branch merge. These include:
> # Remove names from TODOs (e.g. KK) and add JIRA numbers for follow-up work.
> # Fix tests that have been commented out in earlier patches on the branch.
> # Double check method and field visibility of newly added code.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
---------------------------------------------------------------------
To unsubscribe, e-mail: yarn-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: yarn-issues-h...@hadoop.apache.org
