[
https://issues.apache.org/jira/browse/YARN-4206?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15675011#comment-15675011
]
Jian He edited comment on YARN-4206 at 11/18/16 3:07 AM:
---------------------------------------------------------
looks good overall ,thanks Rohith, few comments
- what is this code for, we can remove?
{code}
if (this.applicationTimeouts.isEmpty()) {
} else {
}
{code}
- could you add comments for the API in ApplicationTimeout ?
- updateTimeout, maybe call it updateLifeTimeout?
was (Author: jianhe):
looks good overall ,thanks Rohith, few comments
- what is this code for, we can remove?
{code}
if (this.applicationTimeouts.isEmpty()) {
} else {
}
{code}
- could you add comments for the API in ApplicationTimeout ?
> Add life time value in Application report and CLI
> -------------------------------------------------
>
> Key: YARN-4206
> URL: https://issues.apache.org/jira/browse/YARN-4206
> Project: Hadoop YARN
> Issue Type: Sub-task
> Components: scheduler
> Reporter: nijel
> Assignee: Rohith Sharma K S
> Attachments: YARN-4506.1.patch
>
>
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
---------------------------------------------------------------------
To unsubscribe, e-mail: yarn-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: yarn-issues-h...@hadoop.apache.org
