[ 
https://issues.apache.org/jira/browse/YARN-5761?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15678549#comment-15678549
 ] 

Sunil G commented on YARN-5761:
-------------------------------

Thanks [~xgong]. Sorry jumping in late.

Few comments

1. {{getAndCheckLeafQueue}} Exception seems only related to Move Queue 
operation. It is a public api and hence we can give a general exception there.
2. Could YarnAuthorizationProvider instance in CapacitySchedulerQueueManager 
also be final. Are we supposed to change it during runtime?

> Separate QueueManager from Scheduler
> ------------------------------------
>
>                 Key: YARN-5761
>                 URL: https://issues.apache.org/jira/browse/YARN-5761
>             Project: Hadoop YARN
>          Issue Type: Sub-task
>          Components: capacityscheduler
>            Reporter: Xuan Gong
>            Assignee: Xuan Gong
>              Labels: oct16-medium
>         Attachments: YARN-5761.1.patch, YARN-5761.1.rebase.patch, 
> YARN-5761.2.patch, YARN-5761.3.patch, YARN-5761.4.patch, YARN-5761.5.patch, 
> YARN-5761.6.patch
>
>
> Currently, in scheduler code, we are doing queue manager and scheduling work. 
> We'd better separate the queue manager out of scheduler logic. In that case, 
> it would be much easier and safer to extend.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

---------------------------------------------------------------------
To unsubscribe, e-mail: yarn-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: yarn-issues-h...@hadoop.apache.org

Reply via email to