[
https://issues.apache.org/jira/browse/YARN-5839?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15707020#comment-15707020
]
Carlo Curino edited comment on YARN-5839 at 11/30/16 12:21 AM:
---------------------------------------------------------------
[~seanpo03] thanks for contributing this. Seems like a simple and useful
addition to YARN.
Some issues below:
# In your tests you tend to use {{assertTrue}} with equality predicates in it.
Using {{Assert.equals}} is a bit better, since in case of failures you have a
log that gives you expected/actual values, instead of just knowing the values
are not equal (often speeds up debugging).
# do we ever envision apps to be moved across reservations? (like we allow
among queues?) (just a curiosity, doesn't affect this patch).
# why you changed {{TestRMWebServicesReservation.MINIMUM_RESOURCE_DURATION}}?
# why did you shortened {{submit-reservation.json}} by removing the second
alternative? In general, this is not the same.
# do you have this running in a live cluster? (could help make sure we don't
miss anything... what I saw is mostly good, but it is easy to overlook stuff in
this type of JIRAs).
was (Author: curino):
[~seanpo03] thanks for contributing this. Seems like a simple and useful
addition to YARN.
Some issues below:
# In your tests you tend to use {{assertTrue}} with equality predicates in it.
Using {{Assert.equals}} is a bit better, since in case of failures you have a
log that gives you expected/actual values, instead of just knowing the values
are not equal (often speeds up debugging).
# do we ever envision apps to be moved across reservations? (like we allow
among queues?) (just a curiosity, doesn't affect this patch).
# why you changed {{TestRMWebServicesReservation.MINIMUM_RESOURCE_DURATION}}?
# why did you shortened {{submit-reservation.json}} by removing the second
alternative? In general, this is not the same.
> ClusterApplication API does not include a ReservationID
> -------------------------------------------------------
>
> Key: YARN-5839
> URL: https://issues.apache.org/jira/browse/YARN-5839
> Project: Hadoop YARN
> Issue Type: Improvement
> Reporter: Sean Po
> Assignee: Sean Po
> Attachments: YARN-5839.v001.patch, YARN-5839.v002.patch,
> YARN-5839.v003.patch
>
>
> Currently, the ClusterApplication, and ClusterApplications API does not allow
> users to find the reservation queue that an application is running in.
> YARN-5839 proposes to add ReservationId to the ClusterApplication and
> ClusterApplications API.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
---------------------------------------------------------------------
To unsubscribe, e-mail: yarn-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: yarn-issues-h...@hadoop.apache.org
