[
https://issues.apache.org/jira/browse/YARN-5435?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15707056#comment-15707056
]
Carlo Curino commented on YARN-5435:
------------------------------------
Thanks [~seanpo03] for working on this. Few comments below.
# in {{setupConfigurableCapacities}} you do null checks on parent. This should
never happens right? Is null-check the right behavior?
# do you see any way for us to "harden" our tests more. The bug you are fixing
is similar to other changes in {{FairScheduler}} that broke its compatibility
with the ReservationSystem. In that case was due to someone disabling tests
(GRRR!!) in this case, I think we simply did not had enough coverage. Do you
think we could anything to help prevent this type of issues? (Maybe more
end-to-end type tests using Minicluster?)
# use {{assertEquals}} when checking for equalities, instead of {{assertTrue}}
(more insightful logs when failing)
# I see you have repaired things for the {{NO_LABEL}} case. We have some
pending work for support of node labels in the ReservationSystem, that
[~atumanov] was driving. Any chance to adapt this JIRA to start making that
easier? (open question, while this is a fast bug-fix so ok to say no).
> [Regression] QueueCapacities not being updated for dynamic ReservationQueue
> ---------------------------------------------------------------------------
>
> Key: YARN-5435
> URL: https://issues.apache.org/jira/browse/YARN-5435
> Project: Hadoop YARN
> Issue Type: Bug
> Components: capacity scheduler, resourcemanager
> Affects Versions: 2.8.0
> Reporter: Sean Po
> Assignee: Sean Po
> Labels: oct16-easy, regression
> Attachments: YARN-5435.v003.patch, YARN-5435.v004.patch,
> YARN-5435.v005.patch, YARN-5435.v1.patch, YARN-5435.v2.patch
>
>
> YARN-1707 added dynamic queues (ReservationQueue) to CapacityScheduler. The
> QueueCapacities data structure was added subsequently but is not being
> updated correctly for ReservationQueue. This JIRA tracks the changes required
> to update QueueCapacities of ReservationQueue correctly.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
---------------------------------------------------------------------
To unsubscribe, e-mail: yarn-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: yarn-issues-h...@hadoop.apache.org
