[ https://issues.apache.org/jira/browse/YARN-5559?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15707718#comment-15707718 ]
Akira Ajisaka edited comment on YARN-5559 at 11/30/16 6:34 AM: --------------------------------------------------------------- bq. Found that the getter/setter name is inconsistent, make it set/getNodeLabels ? {{public abstract Set<NodeLabel> getNodeLabels()}} already exists, so we cannot make {{getNodeLabelsList()}} to {{getNodeLabels()}}. Instead, we can make {{setNodeLabels(List<NodeLabel>)}} to {{setNodeLabelsList(List<NodeLabel>)}}. What do you think? bq. I still think we don't need to add back this config, it is only used by RM's own code, user code is not using this. your opinion ? Agreed. was (Author: ajisakaa): bq. Found that the getter/setter name is inconsistent, make it set/getNodeLabels ? {{public abstract Set<NodeLabel> getNodeLabels()}} already exists, so we cannot make {{getNodeLabelsList()}} to {{getNodeLabels()}}. Instead, we can make {{setNodeLabels()}} to {{setNodeLabelsList()}}. What do you think? bq. I still think we don't need to add back this config, it is only used by RM's own code, user code is not using this. your opinion ? Agreed. > Analyse 2.8.0/3.0.0 jdiff reports and fix any issues > ---------------------------------------------------- > > Key: YARN-5559 > URL: https://issues.apache.org/jira/browse/YARN-5559 > Project: Hadoop YARN > Issue Type: Bug > Components: resourcemanager > Reporter: Wangda Tan > Assignee: Akira Ajisaka > Priority: Blocker > Labels: oct16-easy > Attachments: YARN-5559.1.patch, YARN-5559.2.patch, YARN-5559.3.patch > > -- This message was sent by Atlassian JIRA (v6.3.4#6332) --------------------------------------------------------------------- To unsubscribe, e-mail: yarn-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: yarn-issues-h...@hadoop.apache.org