[
https://issues.apache.org/jira/browse/YARN-5932?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15709783#comment-15709783
]
Jian He commented on YARN-5932:
-------------------------------
one question about move, what if the target queue goes over its capacity limit,
will the move continue ?
- change this to if (! (Running && accepted) ) ?
{code}
if (EnumSet.of(RMAppState.NEW, RMAppState.NEW_SAVING, RMAppState.SUBMITTED,
RMAppState.FINAL_SAVING, RMAppState.FINISHING, RMAppState.FINISHED,
RMAppState.KILLED, RMAppState.KILLING, RMAppState.FAILED)
{code}
- the type cast is not needed
{code}
((RMAppImpl) app).setQueue(queue);
FSAppAttempt attempt = (FSAppAttempt) app.getCurrentAppAttempt();
{code}
> Retrospect moveApplicationToQueue in align with YARN-5611
> ---------------------------------------------------------
>
> Key: YARN-5932
> URL: https://issues.apache.org/jira/browse/YARN-5932
> Project: Hadoop YARN
> Issue Type: Bug
> Components: capacity scheduler, resourcemanager
> Reporter: Sunil G
> Assignee: Sunil G
> Attachments: YARN-5932.v0.patch, YARN-5932.v1.patch
>
>
> All dynamic api's of an application's state change could follow a general
> design approach. Currently priority and app timeouts are following this
> approach all corner cases.
> *Steps*
> - Do a pre-validate check to ensure that changes are fine.
> - Update this information to state-store
> - Perform real move operation and update in-memory data structures.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
---------------------------------------------------------------------
To unsubscribe, e-mail: yarn-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: yarn-issues-h...@hadoop.apache.org
